That is incorrect, Turkey, not Erdogan, sees Azerbaijan along with some Balkans countries are their sphere of influence due to historic ties, Turkic languages, and potential for economic and military cooperation. Nothing specific to Turkey, standard geopolitics, still has absolutely nothing to do with the drivel about some sort of "Turkish-Israeli conflict using Israeli weapons".
There is no anticipation of ROI, requires forecasting, requires data, not an easy question to answer on a form. If you need to ask it is likely not a good investment, as mentioned, there are easier more hands off investments that are accessible and come with far less risk. As for citizenship, Turkish citizenship doesn't really possess much benefit in terms of visa free travel, why would it be desired?